Skip to content

feat: custom sample slicing UI#436

Merged
ford442 merged 1 commit intomainfrom
custom-slicing-ui-17472440830562921105
Apr 12, 2026
Merged

feat: custom sample slicing UI#436
ford442 merged 1 commit intomainfrom
custom-slicing-ui-17472440830562921105

Conversation

@ford442
Copy link
Copy Markdown
Owner

@ford442 ford442 commented Apr 11, 2026

Resolves the "Custom Sample Slicing UI" backlog item from agent_plan.md.

  • WaveformDisplay: Added mouse interactions (mousedown, mousemove, mouseup, dblclick) to enable dragging to move markers, double-clicking to remove, and clicking empty space to insert new slice markers.
  • SamplerPanel: Connected the custom slicing UI to the engine and added state tracking to ensure the visual canvas updates dynamically as markers are modified.
  • useAudioEngine / sampleManagement: Exposed the setAlignment function to allow manual overriding of automatically generated phoneme slices.
  • agent_plan.md: Marked the task as completed and appended a new idea ("Real-time Convolution Reverb for Vocal Spaces") to the Innovation Lab.

PR created automatically by Jules for task 17472440830562921105 started by @ford442

Add a waveform view to `SamplerPanel` that allows users to manually
add, move, and remove transient markers for slicing a custom WAV file.
This includes updates to `WaveformDisplay` to handle mouse events,
`SamplerPanel` to sync the state, and `useAudioEngine` to track the
alignment objects via `setAlignment`.

Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ford442 ford442 merged commit aab23b3 into main Apr 12, 2026
1 check passed
@ford442 ford442 deleted the custom-slicing-ui-17472440830562921105 branch April 12, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant